pkg/webhook: k8s.io/api/admission/v1beta1 is deprecated in v1.19

[estroz]

See kubernetes/kubernetes#90300. Bumping to v1 is a breaking change.

/cc @vincepri @DirectXMan12

[estroz]

v1beta1 {Mutating,Validating}WebhookConfigurations have been deprecated for awhile now (v1.16), see kubernetes/kubernetes#90301. Perhaps it's worth removing support for them as well.

[alvaroaleman]

I don't think we can remove support for v1beta1 webhooksconfigurations because the major cloudproviders lack so severly behind in versions. GKE does support 1.16, but its not the default. Not sure about AKS and EKS.

[estroz]

Right. I think v1 and v1beta1 can coexist, with v1beta1 types/methods having a Legacy suffix. This would still be a breaking change, but probably should be to notify users that webhook defaults are changing and that they should upgrade if possible. Thoughts?

[alvaroaleman]

sgtm. Maybe also add a comment telling users the minimum version needed (I believe its v1.16 for v1)

[vincepri]

SGTM, let's do it :)

[jiachengxu]

/assign

[adrianludwin]

Was this fixed by #1284 ?

[estroz]

@adrianludwin yes!

/close

[adrianludwin]

Thanks!