Skip to content

Commit

Permalink
[TT-8166]: fix graphql persist enabled middleware (#4917)
Browse files Browse the repository at this point in the history
<!-- Provide a general summary of your changes in the Title above -->

## Description
This ticket fixes an issue where the persist graphql middleware is
always run for tyk apis. The expected behavior is the middleware should
only run if there are versions that support it.

[TT-8166](https://tyktech.atlassian.net/browse/TT-8166)
<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


[TT-8166]:
https://tyktech.atlassian.net/browse/TT-8166?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
  • Loading branch information
kofoworola authored Mar 31, 2023
1 parent 96543f2 commit fbfaa7a
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion gateway/mw_persist_graphql_operation.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ func (i *PersistGraphQLOperationMiddleware) Name() string {
}

func (i *PersistGraphQLOperationMiddleware) EnabledForSpec() bool {
return true
for _, v := range i.Spec.VersionData.Versions {
if len(v.ExtendedPaths.PersistGraphQL) > 0 {
return true
}
}

return false
}

type GraphQLRequest struct {
Expand Down

0 comments on commit fbfaa7a

Please sign in to comment.