Merging to release-5-lts: [TT-10109] Fix policy lookup map distortion (#5730) #5744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://tyktech.atlassian.net/browse/TT-10109 The policy lookup map is distorted by `ApplyPolicies` function so it ends up wrong path base permission values in the session object. See how it gets the original policy object and changes values inside it: https://github.com/TykTechnologies/tyk/blob/6c6b1535921543d2e2f34d65bbba7d67baffb547/gateway/middleware.go#L493 (cherry picked from commit d18ea51)
Apply Sweep Rules to your PR?
|
|
API Changes no api changes detected |
|
SonarCloud Quality Gate failed.
|
buger
deleted the
merge/release-5-lts/d18ea51248b45909c4ed77d271325365c3d84067
branch
|
API tests result: success ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-10109 Fix policy lookup map distortion (#5730)
https://tyktech.atlassian.net/browse/TT-10109
The policy lookup map is distorted by
ApplyPoliciesfunction so itends up wrong path base permission values in the session object.
See how it gets the original policy object and changes values inside it:
tyk/gateway/middleware.go
Line 493 in 6c6b153