Added Redactor II support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(angular.isDefined(editor)) { | ||
| $timeout(function() { | ||
| element.redactor('code.set', ngModel.$viewValue || ''); | ||
| scope.redactorLoaded = true; |
There was a problem hiding this comment.
This is missing the code that hides the placeholder. The new method in redactor is placeholder.hide
|
Thanks for the contribution |
TylerGarlick
pushed a commit
that referenced
this pull request
Feb 24, 2016
Added Redactor II support
|
Merging this PR, breaks the ability for a user to pass in a callback when the directive is initialized. The comments I made and code samples I gave fix this issue. It also doesn't clear out the placeholder, which is a nice UX for the less tech savvy user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.