Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I click the DragHandleButton quickly, menu button is disappear #1183

Closed
hoongding opened this issue Oct 25, 2024 · 3 comments · Fixed by #1184
Closed

When I click the DragHandleButton quickly, menu button is disappear #1183

hoongding opened this issue Oct 25, 2024 · 3 comments · Fixed by #1184
Labels
bug Something isn't working

Comments

@hoongding
Copy link
Contributor

Describe the bug
When I click the side menu button(DragHandleButton) quickly, menu button is disappear.
How to prevent the side menu from disappearing?

To Reproduce

[ In my product ]

2024-10-25.16.47.30.mov

[ In Blocknote Example Page ]

2024-10-25.16.48.55.mov

Misc

  • Node version: v18.18.0
  • Package manager: pnpm
  • Browser: chrome
@hoongding hoongding added the bug Something isn't working label Oct 25, 2024
@hoongding hoongding changed the title When I click the side menu button(DragHandleButton) quickly, menu button is disappear When I click the DragHandleButton quickly, menu button is disappear Oct 25, 2024
hoongding added a commit to hoongding/BlockNote that referenced this issue Oct 25, 2024
@hoongding
fix: add show state control in freezeMenu
6131cfb 
TypeCellOS#1183
@hoongding hoongding mentioned this issue Oct 25, 2024
Merged
@YousefED
Copy link
Collaborator

Thanks for the PR. I can't reproduce this issue, you have it on https://www.blocknotejs.org/examples/ui-components/side-menu-drag-handle-items?

Does it happen on single or double click?

@hoongding
Copy link
Contributor Author

hoongding commented Oct 25, 2024 •
edited
Loading

This is reproduced from https://www.blocknotejs.org/examples/ui-components/side-menu-drag-handle-items!
Quickly click the DragHandleButton several times to reproduce!
Try clicking 3 or 4 times instead of a single or double click!

@hoongding
Copy link
Contributor Author

@YousefED
By any chance, have you tried reproducing the issue I posted?
If so, could you please provide some feedback on my PR?

matthewlipski pushed a commit that referenced this issue Nov 18, 2024
@hoongding
fix: add show state control in freezeMenu (#1184)
6239f98 
#1183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent menu button from disappearing after fast clicks on DragHandleButton hoongding/BlockNote
2 participants
@YousefED @hoongding