Remove some non null assertion operator #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kody-liou is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
kody-liu
commented
Sep 7, 2024
kody-liu
force-pushed
the
Remove-some-non-null-assertion-operator
branch
3 times, most recently
from
5e5920a to
7891145
Compare
matthewlipski
requested changes
Sep 9, 2024
This reverts commit 58b37d5.
…l-assertion-operator
|
Done. I’ve removed the prepare script and the version bump. This PR now only includes the non-null assertion changes. |
|
Awesome thx! |
matthewlipski
approved these changes
Sep 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed some non-null assertion operators, which should fix this issue: #968.
By the way, does anyone know how to install BlockNote via a GitHub repository URL? I tried adding a prepare script but encountered an error. You can see more details in my comment below.