fix: ShadCN: inherit <a> styling for inline content #1228
Conversation
By default, links are not styled when using ShadCN (and therefore hard to recognise). This patch makes them inherit the browser default, matching the Mantine behaviour.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@serpent213 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
@matthewlipski should this be added in this file or separately? If this file is meant as "Do not modify, it's copied directly from xxx", maybe mark it as such and add the change somewhere else?
Yeah you're right, I changed it so the link styling gets reverted in |
# Conflicts: # tests/src/end-to-end/shadcn/shadcn.test.ts-snapshots/shadcn-link-toolbar-chromium-linux.png # tests/src/end-to-end/shadcn/shadcn.test.ts-snapshots/shadcn-link-toolbar-firefox-linux.png # tests/src/end-to-end/shadcn/shadcn.test.ts-snapshots/shadcn-link-toolbar-webkit-linux.png
By default, links are not styled when using ShadCN (and therefore hard to recognise). This patch makes them inherit the browser default, matching the Mantine behaviour.
(Not sure this is the preferred way to fix it...)