Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove redundant zindex values #1257

Merged
merged 5 commits into from
Nov 20, 2024
Merged

fix: Remove redundant zindex values #1257

merged 5 commits into from
Nov 20, 2024

Conversation

YousefED
Copy link
Collaborator

I think we went a little overboard on zIndex values.

I think this makes more sense, wdyt? can you check if the changes are "safe"?

@YousefED YousefED marked this pull request as ready for review November 18, 2024 10:32
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Nov 20, 2024 4:21pm
blocknote-website 🛑 Canceled (Inspect) Nov 20, 2024 4:21pm

Copy link
Collaborator

@matthewlipski matthewlipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm while we're on the subject of z-indices maybe we should also take a look at the UI element controllers? Those also have the z-index set but it's between 1000-10000. I think it would make sense if we had the same scale for both those and the examples.

@matthewlipski
Copy link
Collaborator

Well turns out the z-indices were just redundant, so I ended up removing them

@matthewlipski matthewlipski changed the title fix: sane zindex values fix: Remove redundant zindex values Nov 20, 2024
@matthewlipski matthewlipski merged commit 82c463f into main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants