feat: Code block support in PDF & DOCX exporters #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
areknawo
commented
Jan 13, 2025
areknawo
commented
- Support for code block in PDF & DOCX exporters as a separate block with a monospace font;
- Use Geist Mono font for code in PDF & DOCX exports;
- Update examples for PDF & DOCX exporters to include code blocks;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
requested changes
Jan 13, 2025
examples/05-interoperability/06-converting-blocks-to-docx/App.tsx
Outdated
Show resolved
Hide resolved
| // text: block..type + " not implemented", | ||
| // }), | ||
| // ], | ||
| run: { |
There was a problem hiding this comment.
it might be nicer to define this style externally (in styles.xml). Optional if you want to do this for this PR, but it's good to know the file exists and how it works when you start working on other exporter related PRs
There was a problem hiding this comment.
Moved everything except shading - it seems to apply differently from <w:shd/> in styles.xml (doesn't result in uniform background). I might be missing something here though, so let me know if you have any insight into that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.