atom fix #126
atom fix #126
Conversation
|
As I mentions in PR #125, this actually seems to fix another issue with DnD, so this definitely is doing something... |
@pvunderink I've opened #126 (comment) which is a partial copy of this PR. I think that should also fix the typecell drag issue you mentioned. For the ignoreMutation part, my previous comment stays; I would expect it's necessary and think it could solve some things, but unless we know what, let's not merge yet |
There was a problem hiding this comment.
Looks good. Overall I would say the editor behaviour in this branch feels stable (more stable than in #86).
I haven't found a concrete bug that is fixed by the ignoreMutation part, but if we need a custom NodeView for our typecell editor in the future we can revisit this when implementing the custom NodeView.
|
Closing this as it should be handled by ueberdosis/tiptap#1448, and we didn't run into concrete breaking issues |
This is a hardcoded fix for ueberdosis/tiptap#1448.
While working on the drag fix, I think this resolved some internal prosemirror issues. However, the other drag fix seems to work fine now.
I expect this code (maybe just the ignoreMutation + contentDOM part, and not the stopEvent), might resolve some other issues, but I don't want to merge it before we know exactly which cases it resolves