DRAFT - Update Language Client to 6.0.0 #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
requested review from
akosyakov,
AlexTugarev,
asual,
BroKun,
gatesn,
johnwiseheart,
mofux and
rcjsuen
as code owners
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
apupier
force-pushed
the
196-updateLanguageClient
branch
from
c1f212e
to
48ed562
Compare
- requires upgrade of TtypeScript to 3.7.5 to avoid "error TS1086: An
accessor cannot be declared in an ambient context.
"
- requires API updates:
-- client/src/monaco-language-client.ts createMessageTransports now
using Promise instead of Thenable
-- vscode-uri Uri has been renamed URI
-- registerCallHierarchyProvider has moved from workspace to languages
remaining:
monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.
monaco-languageclient: src/vscode-api.ts(209,17): error TS2322: Type
'(arg0: Uri, arg1: readonly Diagnostic[] | undefined) => void' is not
assignable to type '{ (uri: Uri, diagnostics: readonly Diagnostic[] |
undefined): void; (entries: readonly [Uri, readonly Diagnostic[] |
undefined][]): void; }'.
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
monaco-languageclient: src/vscode-api.ts(52,11): error TS2740: Type '{
createFileSystemWatcher(globPattern: GlobPattern, ignoreCreateEvents:
boolean | undefined, ignoreChangeEvents: boolean | undefined,
ignoreDeleteEvents: boolean | undefined): FileSystemWatcher; ... 21 more
...; name: undefined; }' is missing the following properties from type
'typeof workspace': fs, workspaceFile, onWillCreateFiles,
onDidCreateFiles, and 4 more.
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
196-updateLanguageClient
branch
from
337287d
to
b5e0e8c
Compare
|
hum in fact, seems that compilation errro are nto all reported when there is a previous one, here is a bunch of other: |
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
I see similar errors in the PR #198. |
Closed
|
@apupier ==== upd: checked - some errors are still there, so continue to investigate how to fix them... |
|
seems #199 is more advanced. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error TS1086: An accessor cannot be declared in an ambient context.using Promise instead of Thenable
remaining (but didn't grok what it means, I'm a newbie in typescript):
EDIT:
fixed: