Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since TypeScript now supports filesGlob natively we definitely shouldn't expand it by default #992

Closed
basarat opened this issue Jul 4, 2016 · 4 comments
Closed

Since TypeScript now supports filesGlob natively we definitely shouldn't expand it by default #992

basarat opened this issue Jul 4, 2016 · 4 comments
Assignees
@basarat
Labels
breaking-change

Comments

@basarat
Copy link
Member

basarat commented Jul 4, 2016

No description provided.

@basarat basarat self-assigned this Jul 4, 2016
@basarat basarat closed this as completed in 5a8a53a Jul 4, 2016
@basarat
Copy link
Member Author

basarat commented Jul 4, 2016

Of course the user can explicitly toggle it. Just changed the default to be false 🌹

@basarat
Copy link
Member Author

basarat commented Jul 4, 2016

Released https://github.com/TypeStrong/atom-typescript/releases/tag/v9.0.0 🌹

@pwnall
Copy link
Contributor

pwnall commented Jul 5, 2016

native filesGlob support will come in TS 2.0, which is not yet released -- documenting this for other folks who come here with the same question as me.

References:
microsoft/TypeScript#8841
microsoft/TypeScript#1927

@piotrwitek
Copy link

piotrwitek commented Aug 8, 2016 •
edited
Loading

This post can introduce confusion, it implies that TS will have a native filesGlob option support, which is not the case, instead there is "include" which will serve similar purpose.

References:
microsoft/TypeScript-Handbook#334 (comment)
microsoft/TypeScript#5980

@piotrwitek piotrwitek mentioned this issue Aug 8, 2016
Merged
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
angelestelar5z added a commit to angelestelar5z/atom-typescript that referenced this issue Aug 17, 2024
@angelestelar5z @basarat
closes TypeStrong/atom-typescript#992
6ab4aa7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@basarat basarat

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pwnall @piotrwitek @basarat