-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set "compilationDone" before "forkTsCheckerServiceBeforeStart" #146
Conversation
@piotr-oles what do you think about this? |
Anything I can do to help? I'm blocked at the moment on finding some way of accomplishing this (definitely open to better solutions) |
It's fine with me; but since it represents a change to behaviour I'd like @piotr-oles to review before we merge. He may be on holiday so please bear with us! |
Ps could you merge in upstream changes to your branch? |
Looks good :) Thanks |
Any chance we can get a release with this change? |
Do you want to submit a PR that updates the changelog and the package.json? That will make it easy for me to arrange... See https://github.com/Realytics/fork-ts-checker-webpack-plugin/blob/master/DEPLOYING.md for context |
Sure, opened #152 |
Thanks - release should be out by the time you read this. Thanks again for your work! |
I'm trying to use the
forkTsCheckerServiceBeforeStart
hook to defer type checking until after compilation has finished in order to pick up typings generated on the fly by a loader. In this case, compilation will be finished beforeforkTsCheckerServiceBeforeStart
is resolved. Right nowthis.compilationDone
will be incorrectly set tofalse
, causing the build to hang indefinitely.