Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reportFiles option #179

Merged
merged 4 commits into from
Oct 28, 2018

Conversation

ianschmitz
Copy link
Contributor

Closes #177.

This PR adds a new option reportFiles that behaves the same way as as ts-loader. When an array of file path globs are provided, it will use these globs to filter the ts/tslint diagnostics to only include those matching.

Here is an example using create-react-app where there are no errors in the reportFiles (you can see both __tests__/App.tsx and App.test.tsx have type errors):
image

And an example when there is an error in one of the reportFiles (which is src/App.tsx in this case):
image

/cc @Timer, @johnnyreilly

@johnnyreilly
Copy link
Member

Brilliant! Thanks! ❤️

@Timer
Copy link

Timer commented Oct 28, 2018

You've been killing it with these features, @ianschmitz! Thank you!

@mix0000
Copy link

mix0000 commented Oct 21, 2021

Where this options is gone??? My setup dont works withour reportFiles

@piotr-oles
Copy link
Collaborator

Please use issues hook to filter-out issues that you're not interested in: https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#plugin-hooks :)

@mix0000
Copy link

mix0000 commented Oct 22, 2021

Yes, last night i did it with:

issue: {
  exclude: {
    file: "node_modules/**/*"
  }
}

@dasler-fw
Copy link

Can't find any migration guides. Can someone make it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants