Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use separate workers for dependencies and issues #636

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

piotr-oles
Copy link
Collaborator

@piotr-oles piotr-oles commented Aug 1, 2021

In order to not block the next iteration on the getDependencies call, we use separate worker for dependencies calculations (so getIssues from previous compilation will not block the next getDependencies call)

Closes: #612, #634

It's not a perfect implementation, but the one that requires minimum code change. I will improve this in the next major version.

In order to not block next iteration on getDependencies call, we use
separate worker for dependencies calculations (so getIssues from
previous compilation will not block next getDependencies call)

✅ Closes: #612
@piotr-oles piotr-oles added performance eslint Related to ESLint labels Aug 1, 2021
@piotr-oles piotr-oles requested a review from johnnyreilly August 1, 2021 14:28
@piotr-oles piotr-oles self-assigned this Aug 1, 2021
Copy link
Member

@johnnyreilly johnnyreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@piotr-oles piotr-oles merged commit 4cb7e39 into main Aug 1, 2021
@piotr-oles piotr-oles deleted the feature/separate-workers branch August 1, 2021 15:06
@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 7.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint checking from the 1st compilation blocks 2nd webpack compilation (tapAfterCompileToAddDependencies)
2 participants