Fix project references bug #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we recompute dependencies only if fileNames for the main configuration changes. It doesn't handle the case when we have project references.
In the situation, when there were already some files built in the real fs, controlled typescript system returned true for fileExists call on initial run and false on subsequent calls causing assertion in TypeScript to fail. ✅ Closes: #630
piotr-oles
force-pushed
the
fix/project-references-bug
branch
from
e21827e to
1572c58
Compare
|
🎉 This PR is included in version 6.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 bugs that I found regarding project references:
JSON.stringify(previousParsedConfiguration.fileNames) !== JSON.stringify(parsedConfiguration.fileNames)didn't take into account project references. I changed it to always callgetDependencies()(which takes project references into account) and compare dependencies to detect if list of files changed.realpathmethod overwrite in ControlledTypeScriptSystemfileExistscall on the initial run and false on subsequent runs. This was causing assertion in TypeScript to fail.✅ Closes: #630