-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement write-dts mode #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, I will wait for the CI and if everything is green, we're good to merge :) Thanks for the contribution!
@piotr-oles ping for merge 🙏 |
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@piotr-oles @onigoetz @adriangodong After investigation (look at e2e test), in order to make it work, you need to set the See the working configuration:
I don't know if it was the expected behavior but with this configuration it works. Remove |
🎉 This PR is included in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds a new mode called
write-dts
. When selected, the plugin will emit tsbuildinfo, d.ts, and d.ts.map files. This allows the plugin to work together withts-loader
(withtranspileOnly
set totrue
) orbabel-loader
and emit type definition files.Fixes #663, #658