Skip to content

Commit

Permalink
upgrade react-hot-boilerplate to webpack 4
Browse files Browse the repository at this point in the history
  • Loading branch information
johnnyreilly committed Feb 25, 2018
1 parent 34a528b commit c122c9f
Showing 3 changed files with 2,915 additions and 534 deletions.
12 changes: 6 additions & 6 deletions examples/react-hot-boilerplate/package.json
Original file line number Diff line number Diff line change
@@ -3,9 +3,9 @@
"version": "1.0.0",
"description": "Boilerplate for ReactJS project with hot code reloading",
"scripts": {
"start": "webpack-dev-server",
"start": "webpack-dev-server --mode development",
"prebuild": "rimraf dist",
"build": "cross-env NODE_ENV=production webpack -p --config webpack.config.production.js",
"build": "cross-env webpack --mode production --config webpack.config.production.js",

This comment has been minimized.

Copy link
@nil4

nil4 Mar 6, 2018

Contributor

Is cross-env still needed here when no environment variables are passed?

This comment has been minimized.

Copy link
@johnnyreilly

johnnyreilly Mar 6, 2018

Author Member

Almost certainly not.

This comment has been minimized.

Copy link
@johnnyreilly

johnnyreilly Mar 6, 2018

Author Member

PRs accepted 😉

This comment has been minimized.

Copy link
@nil4

nil4 Mar 7, 2018

Contributor

PR created: #738

"postbuild": "copyfiles index.html dist"
},
"repository": {
@@ -35,15 +35,15 @@
"@types/react-hot-loader": "^3.0.4",
"copyfiles": "^1.2.0",
"cross-env": "^3.1.4",
"fork-ts-checker-webpack-plugin": "^0.2.8",
"fork-ts-checker-webpack-plugin": "^0.4.0",
"react-hot-loader": "^3.0.0",
"rimraf": "^2.6.0",
"ts-loader": "^3.0.0",
"ts-loader": "^4.0.0",
"tslint": "^5.8.0",
"tslint-react": "^3.2.0",
"typescript": "^2.5.3",
"webpack": "^3.0.0",
"webpack-dev-server": "^2.2.0"
"webpack": "^4.0.0",
"webpack-dev-server": "^3.0.0"
},
"dependencies": {
"react": "^16.0.0",
6 changes: 1 addition & 5 deletions examples/react-hot-boilerplate/webpack.config.production.js
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ var webpack = require('webpack');
const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');

module.exports = {
entry: './src/index.js',
entry: './src/index.tsx',

output: {
filename: 'static/bundle.js',
@@ -26,10 +26,6 @@ module.exports = {
},

plugins: [
new webpack.optimize.UglifyJsPlugin({
sourceMap: true,
comments: false
}),
new ForkTsCheckerWebpackPlugin({
tslint: true,
checkSyntacticErrors: true
Loading

0 comments on commit c122c9f

Please sign in to comment.