Fix SolutionBuilder watches #1003

sheetalkamat · 2019-09-13T15:16:16Z

Fixes #998

sheetalkamat · 2019-09-13T15:18:06Z

src/instances.ts

-      { verbose: true, watch: true }
+      { verbose: true }
+    );
+    loader._compiler.hooks.watchRun.tap(


I am not sure if this is correct way to do cleanup before watch compilation begins.. Also I think we need to create solutionbuilder host and solutionBuilder both again but I don't know how to check that..

Edit i checked this isnt right way to do this. I think we need to create with watch host when running with --watch. Can someone let me know how to detect that here?

There should be a watchMode property on the webpack Compiler object: https://github.com/webpack/webpack/pull/8253/files

I think even with that we need to implement watchFile as loader.addDepencedency but that needs more work I think given there are too many places clearing dependencies...

johnnyreilly · 2019-09-13T16:02:39Z

Thanks for this @sheetalkamat!

Copied across from linked issue:

I remembered that this was todo.. While in normal build scenario non watch makes sense but we would want to handle --watch portion of it since webpack wont know about the referenced project's files (to watch).

From looking at the changes here it mostly seems that be dropping usage of the watch APIs. Swapping from createSolutionBuilderWithWatchHost to createSolutionBuilder.

Whilst this fixes the webpack not exiting with project references issue does this mean that watch mode doesn't work for project references with this PR? i.e. If I make a change to a dependent project with this change in place, does that mean that changes will not be picked up / builds retriggered?

I'm not totally clear on the intent of this PR and so wanted to clarify.

Thanks again so much for your time and work!

Bessonov · 2019-09-13T16:38:51Z

Run in the same issue with hanging webpack. Tested this PR (a2a37c). Just building works - webpack exists. But if webpack is in watch mode, then recompilation works only for the current project, but not for referenced one. Does it make sense to synchronize webpack watch mode with typescript watch mode?

sublimator · 2019-09-13T16:45:58Z

Does it make sense to synchronize webpack watch mode with typescript watch mode?

On the surface it would seem so, no?

Are there other contexts other than webpack need to consider as well ? (Personally only ever used ts-loader with webpack)

sheetalkamat · 2019-09-13T16:48:03Z

I am looking into supporting watch mode separately. This mean while should unblock people that just run webpack

sublimator · 2019-09-13T16:49:11Z

@sheetalkamat

Makes sense, sounds good to me :)

sublimator · 2019-09-13T16:49:59Z

src/instances.ts

    );
+    // TODO:: handle --watch?


Ja, if it's tricky, maybe just should roll this out in the short term

Bessonov · 2019-09-13T16:51:52Z

I can unblock with kill, but I can't develop without watch mode. Therefore the watch mode is more critical for me than unblocking. But I'm fine if the next version unblocks and the next one fix the watch mode 👍

sublimator · 2019-09-13T17:02:59Z

@Bessonov
Hanging is a bit painful on CI, but yeah --watch would be --pretty-please-terrific!

johnnyreilly · 2019-09-13T17:06:27Z

I'm happy for this to be merged and released as v6.1.1 - is there anything more to do?

~~If not, would you like to update the package.json / CHANGELOG.md?~~

Done it; love that GitHub makes editing a PRs branch possible by default now!

Are we good to merge this when Travis / AppVeyor are finished?

sublimator · 2019-09-13T17:35:22Z

Ran the branch and it fails on the first invokation.
Works on the subsequent?

sublimator · 2019-09-13T17:37:37Z

➜  3.6.0_projectReferencesToBeBuilt git:(fixWatch) ✗ rm lib/tsconfig.tsbuildinfo 
➜  3.6.0_projectReferencesToBeBuilt git:(fixWatch) ✗ rm lib/index.js.map 
➜  3.6.0_projectReferencesToBeBuilt git:(fixWatch) ✗ rm lib/index.d.ts 
➜  3.6.0_projectReferencesToBeBuilt git:(fixWatch) ✗ node ../../../node_modules/.bin/webpack-cli --config webpack.config.js
Hash: 1723e4ce27cdd156732c
Version: webpack 4.20.2
Time: 2933ms
Built at: 09/14/2019 12:36:30 AM
    Asset      Size  Chunks             Chunk Names
bundle.js  4.27 KiB    main  [emitted]  main
Entrypoint main = bundle.js
[./src/app.ts] 518 bytes {main} [built] [failed] [1 error]

ERROR in ./src/app.ts
Module build failed (from /Users/nicholasdudfield/projects/ts-loader/index.js):
Error: TypeScript emitted no output for /Users/nicholasdudfield/projects/ts-loader/test/execution-tests/3.6.0_projectReferencesToBeBuilt/src/app.ts.
    at makeSourceMapAndFinish (/Users/nicholasdudfield/projects/ts-loader/dist/index.js:78:15)
    at successLoader (/Users/nicholasdudfield/projects/ts-loader/dist/index.js:68:9)
    at Object.loader (/Users/nicholasdudfield/projects/ts-loader/dist/index.js:22:12)

(edit: broke up this for easier reading)

➜  3.6.0_projectReferencesToBeBuilt git:(fixWatch) ✗ node ../../../node_modules/.bin/webpack-cli --config webpack.config.js
Hash: 44ad6121c445f269b58c
Version: webpack 4.20.2
Time: 2207ms
Built at: 09/14/2019 12:36:35 AM
    Asset      Size  Chunks             Chunk Names
bundle.js  4.39 KiB    main  [emitted]  main
Entrypoint main = bundle.js
[./lib/index.ts] 97 bytes {main} [built]
[./src/app.ts] 221 bytes {main} [built]
➜  3.6.0_projectReferencesToBeBuilt git:(fixWatch) ✗

Hrmm, something is up

sublimator · 2019-09-13T17:41:30Z

And if you delete just one of the js files it gets "stuck", unable to recover with the error above

johnnyreilly · 2019-09-13T17:45:00Z

Thanks for testing and reporting with detail @sublimator. @sheetalkamat - it looks like there's still issues.

sheetalkamat · 2019-09-13T19:58:46Z

Looking into it

sheetalkamat · 2019-09-13T21:59:55Z

Note:: This should fix initial thing but still working on it.. (reporting error and I think watch)

sheetalkamat · 2019-09-13T22:00:23Z

Are there tests reporting error that I can see sample of to add test to it

sheetalkamat · 2019-09-13T23:54:45Z

Also note that I know there are tests for project references failing on older build because I was trying to work clean slate.. Once this work is stabilized, will add the deleted code back.

sublimator · 2019-09-14T03:03:42Z

@sheetalkamat
Let me know when ready for some testing :)
Thanks!

johnnyreilly · 2019-09-14T05:17:19Z

Are there tests reporting error that I can see sample of to add test to it

I think what you're looking for is a comparison test. There's a specific test that you could clone if you wanted to create a new comparison test which specifically tests for an expected error case:

https://github.com/TypeStrong/ts-loader/tree/master/test/comparison-tests/errors

Details of how you can work with comparison tests can be found here: https://github.com/TypeStrong/ts-loader/blob/master/test/comparison-tests/README.md

Does that give you what you need?

sheetalkamat · 2019-09-16T19:36:00Z

@johnnyreilly Thank you for the pointer.. That's exactly what I needed..

johnnyreilly · 2019-09-17T05:15:44Z

We are green! Are you ready for this to be merged and released @sheetalkamat?

sheetalkamat · 2019-09-17T14:53:36Z

Will look into --watch today and if that takes longer, we can merge this? Will let you know..

test/comparison-tests/projectReferences/expectedOutput-3.6/bundle.js

sheetalkamat · 2019-09-18T15:33:01Z

Of course tsc -b recovers from this situation, so it would be an expectation that webpack/ts-loader can as well ?

tsc -b does not handle that scenario (Refer microsoft/TypeScript#30602)

c:\temp\test>node c:\TypeScript\built\local\tsc.js -b  --clean

c:\temp\test>node c:\TypeScript\built\local\tsc.js -b

c:\temp\test>dir main.js
 Volume in drive C is OSDisk
 Volume Serial Number is F41A-DBC9

 Directory of c:\temp\test

09/18/2019  08:19 AM                43 main.js
               1 File(s)             43 bytes
               0 Dir(s)  809,078,542,336 bytes free

c:\temp\test>del main.js

c:\temp\test>node c:\TypeScript\built\local\tsc.js -b

c:\temp\test>dir main.js
 Volume in drive C is OSDisk
 Volume Serial Number is F41A-DBC9

 Directory of c:\temp\test

File Not Found

c:\temp\test>

sublimator · 2019-09-18T15:36:43Z

I tested it. Tsc -b definitely worked for me. I was on MacOS though. Currently out at the moment. Will test again when I get home.

sublimator · 2019-09-18T16:34:05Z

Note that the deleted file in my test was in reference project, not the primary one, if that means anything?

sublimator · 2019-09-18T16:34:28Z

Still haven’t tested btw

…write new files

…oject

johnnyreilly · 2019-09-18T21:28:26Z

@sublimator have you had chance to test with @sheetalkamat's latest changes? It sounds like we may be there, I'd love to get you to try it out and confirm.

sheetalkamat · 2019-09-18T23:12:59Z

@johnnyreilly I think this should be it for this PR,., This still doesn't emit .tsbuildinfo for current program when using experimentalWatchAPI( note its not possible to get the .tsbuildinfo from language service as its not meant for that). But that's a separate issue than supporting project references.
Also I had to copy few things from typescript but I will shortly open PR that will have the apis for those things..

sheetalkamat · 2019-09-18T23:14:20Z

@sublimator as mentioned at #1003 (comment) deleting js file from referenced project's output is not supported scenario even with tsc --b

sublimator · 2019-09-19T03:14:19Z

@sheetalkamat
Sorry, just got to my computer

I am referring to a leaf project as per:

Although, editing that test project to make the entry point "main" tsconfig.json have compilerOptions composite: true seems to work too??
(edit: actually, you don't even need to change the entry point to composite: true??)

Is this a windows vs MacOS thing ??

sublimator · 2019-09-19T03:57:42Z

@sheetalkamat
https://github.com/microsoft/TypeScript/blob/master/src/compiler/diagnosticMessages.json#L4055-L4059

sheetalkamat · 2019-09-19T04:35:50Z

@sheetalkamat
https://github.com/microsoft/TypeScript/blob/master/src/compiler/diagnosticMessages.json#L4055-L4059

That is the message that indicates to build but does not really build.. Check out the microsoft/TypeScript#30602 as per my earlier comment. that's not something that would be fixed here.

sublimator · 2019-09-19T04:55:14Z

@sheetalkamat

I don't know why I'm getting different results than you, but it's definitely building for me ??

johnnyreilly · 2019-09-19T05:00:40Z

Let's get this merged and released. There's been a ton of progress here - thanks so much @sheetalkamat! If there's further things to do they can be addressed subsequently.

sublimator · 2019-09-19T05:18:21Z

Yeah, don't mean to come off as ungrateful :)
Just reporting my findings. I can't explain it ?? MacOS vs Windows differences ??
Having a play now with the 'sweet path'

sublimator · 2019-09-19T05:22:25Z

--watch mode seems to be working, and picking up changes!
normal mode seems to be working and picking up changes!

sheetalkamat commented Sep 13, 2019

View reviewed changes

sublimator reviewed Sep 13, 2019

View reviewed changes

src/instances.ts Outdated

);

// TODO:: handle --watch?

Copy link

sublimator Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, if it's tricky, maybe just should roll this out in the short term

sheetalkamat added 2 commits September 13, 2019 15:40

Fix simple run to start with

0126b68

Try with --watch

b38854c

More fixes

23d3e90

sheetalkamat added 3 commits September 16, 2019 13:01

Tests for errors

d6fb955

Add back the deleted code

46ce766

More changes to provide correct errors

6c60ab0

johnnyreilly mentioned this pull request Sep 17, 2019

Strange behavior with Project References on #997

Closed

sublimator reviewed Sep 18, 2019

View reviewed changes

test/comparison-tests/projectReferences/expectedOutput-3.6/bundle.js Show resolved Hide resolved

e00dan mentioned this pull request Sep 18, 2019

chore: decrease UI build size energywebfoundation/origin#43

Merged

1 task

sheetalkamat added 3 commits September 18, 2019 11:53

Add alias loader so its easy to run from command line

1e5e231

Fix incorrect scheduling of the next build and fix copy for tests to …

d3c82fb

…write new files

Set tsbuildinfo as asset only if emitting the file from referenced pr…

0cadb2c

…oject

sheetalkamat added 3 commits September 18, 2019 15:01

Add support when the file is referenced indirectly from project

8b5578f

Support when referenced project is already built

6458311

Additional guidance for no emit when referenced file build is failed

392eefd

Solution errors per module

42cb006

johnnyreilly merged commit ae0698d into TypeStrong:master Sep 19, 2019

johnnyreilly mentioned this pull request Sep 19, 2019

Prepare for 6.1.1 release #1010

Merged

sheetalkamat mentioned this pull request Sep 19, 2019

Add output file names api for supporting ts-loader microsoft/TypeScript#33503

Merged

sheetalkamat deleted the fixWatch branch September 19, 2019 06:00

johnnyreilly mentioned this pull request Sep 19, 2019

3.6 was missing from Travis / AppVeyor build matrices. #1011

Merged

snyk-bot mentioned this pull request Oct 27, 2019

[Snyk] Upgrade ts-loader from 2.3.7 to 6.2.0 ajesse11x/howtographql#5

Open

teoxoy mentioned this pull request Dec 1, 2019

WIP for supporting project references further #1028

Closed

Fix SolutionBuilder watches #1003

Fix SolutionBuilder watches #1003

Conversation

sheetalkamat commented Sep 13, 2019

sheetalkamat Sep 13, 2019

Choose a reason for hiding this comment

sheetalkamat Sep 13, 2019

Choose a reason for hiding this comment

andrewbranch Sep 13, 2019

Choose a reason for hiding this comment

sheetalkamat Sep 13, 2019

Choose a reason for hiding this comment

johnnyreilly commented Sep 13, 2019 • edited Loading

Bessonov commented Sep 13, 2019 • edited Loading

sublimator commented Sep 13, 2019 • edited Loading

sheetalkamat commented Sep 13, 2019

sublimator commented Sep 13, 2019

sublimator Sep 13, 2019

Choose a reason for hiding this comment

Bessonov commented Sep 13, 2019

sublimator commented Sep 13, 2019

johnnyreilly commented Sep 13, 2019 • edited Loading

sublimator commented Sep 13, 2019

sublimator commented Sep 13, 2019 • edited Loading

sublimator commented Sep 13, 2019

johnnyreilly commented Sep 13, 2019

sheetalkamat commented Sep 13, 2019

sheetalkamat commented Sep 13, 2019

sheetalkamat commented Sep 13, 2019 • edited Loading

sheetalkamat commented Sep 13, 2019

sublimator commented Sep 14, 2019

johnnyreilly commented Sep 14, 2019

sheetalkamat commented Sep 16, 2019

johnnyreilly commented Sep 17, 2019

sheetalkamat commented Sep 17, 2019

sheetalkamat commented Sep 18, 2019 • edited Loading

sublimator commented Sep 18, 2019 via email

sublimator commented Sep 18, 2019 via email

sublimator commented Sep 18, 2019 via email

johnnyreilly commented Sep 18, 2019

sheetalkamat commented Sep 18, 2019 • edited Loading

sheetalkamat commented Sep 18, 2019

sublimator commented Sep 19, 2019 • edited Loading

sublimator commented Sep 19, 2019

sheetalkamat commented Sep 19, 2019

sublimator commented Sep 19, 2019

johnnyreilly commented Sep 19, 2019

sublimator commented Sep 19, 2019

sublimator commented Sep 19, 2019

johnnyreilly commented Sep 13, 2019 •

edited

Loading

Bessonov commented Sep 13, 2019 •

edited

Loading

sublimator commented Sep 13, 2019 •

edited

Loading

johnnyreilly commented Sep 13, 2019 •

edited

Loading

sublimator commented Sep 13, 2019 •

edited

Loading

sheetalkamat commented Sep 13, 2019 •

edited

Loading

sheetalkamat commented Sep 18, 2019 •

edited

Loading

sheetalkamat commented Sep 18, 2019 •

edited

Loading

sublimator commented Sep 19, 2019 •

edited

Loading