-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that JSON files are included in build module resolution (#905) #1101
Ensure that JSON files are included in build module resolution (#905) #1101
Conversation
Ensure that json files are resolved if resolveJsonModule flag is set in tsconfig
Thanks so much for doing this @berickson1! Do you think you’d be able to add a comparison test? |
@andrewbranch - Added a comparison-test for the positive case (& confirmed it didn't work before this change). Should I also add one for when resolveJsonModule is false? |
43d97d6
to
4eb03b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Let me try to channel @johnnyreilly from across the Atlantic—
Great work, chap! 🌻 Could you update the package.json version and add an entry to the CHANGELOG.md too please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is the reason for the failing tests on Travis?
Thanks! |
Shipping with https://github.com/TypeStrong/ts-loader/releases/tag/v7.0.3 ⛴️ |
…trong#905) (TypeStrong#1101) * Fix TypeStrong#905 Ensure that json files are resolved if resolveJsonModule flag is set in tsconfig * Add test * PR Comments
Ensure that json files are resolved if resolveJsonModule flag is set in tsconfig
Fixes #905