Bug fix: support webpack 5 in ts-loader

[einatbar]

Fixes Error when running ts-loader with webpack 5 : "times is not iterable"

closes #1438

[johnnyreilly]

Thanks! Just kicked off the tests

[johnnyreilly]

The build is failing at the moment?

[johnnyreilly]

compiliation.fileSystemInfo._fileTimestamps.stack.forEach(times

I notice this approach depends upon _fileTimestamps - is this API for public consumption? @alexander-akait / @sokra can you advise?

[alexander-akait]

@vankop friendly ping, I think it is regression

[vankop]

hm.. maybe some watch bug.. could you create a small reproducible repo? From code this could happen (fileTimestamps=undefined). so fast fix could be just check that fileTimestamps exists (if (!fileTimestamps) return;)

[johnnyreilly]

This is actually a question about types; we're getting this compilation error:

src/watch-run.ts(33,37): error TS2551: Property '_fileTimestamps' does not exist on type 'FileSystemInfo'

It suggests that there is no available _fileTimestamps property. The fact there is an _ at the start suggests it may be an internal property and intentionally not exposed with a type - is that right?

[vankop]

yes, _fileTimestamps is internal property and is not presented in types.

[johnnyreilly]

Okay cool. Is there a public API that can be used? Is there an fileTimestamps for instance?

[johnnyreilly]

Just looking at the code and I can see there's a getDeprecatedFileTimestamps() method. But the name suggests we shouldn't rely upon it... Is there a non deprecated one by any chance?

https://github.com/webpack/webpack/blob/770dea1fb46c7c5e04016dbab1f0854037b00d81/lib/FileSystemInfo.js#L3537

[johnnyreilly]

@einatbar would you like to update your pr to use getDeprecatedFileTimestamps()? Assuming that works, we could use that as a basis for a conversation with the webpack team about a non deprecated endpoint.

@alexander-akait / @vankop if you have thoughts then please do share!

[vankop]

I think compiler.fileTimestamps should work.. need @sokra to take a look.

[alexander-akait]

I think we should use snapshot API here, there is small example how we do it in copy plugin https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/src/index.js#L569

[vankop]

If I understand correctly this code snippet does:

• watch N files
• if one file changed => regenerate definitions

So you can use 2 api methods createSnapshot (example above) and on watch callback check that snapshot is valid
But this idea seems wrong, since you will need 1 snapshot per file.. (this will decrease build performance)

So I think you can use compiler.modifiedFiles and compiler.removedFiles

---

and it still unclear to me why compiler. fileTimestamps does not work

[einatbar]

and it still unclear to me why compiler. fileTimestamps does not work

@vankop compiler. fileTimestamps is sometimes undefined, which causes the error "times is not iterable".
I am not sure what causes it to be undefined

[johnnyreilly]

and it still unclear to me why compiler.fileTimestamps does not work
@vankop compiler.fileTimestamps is sometimes undefined, which causes the error "times is not iterable".
I am not sure what causes it to be undefined

Would it be enough to guard against compiler.fileTimestamps being undefined?

[einatbar]

Would it be enough to guard against compiler.fileTimestamps being undefined?

@johnnyreilly looks like it's working as well if I just guard against compiler.fileTimestamps

[johnnyreilly]

Would it be enough to guard against compiler.fileTimestamps being undefined?

@johnnyreilly looks like it's working as well if I just guard against compiler.fileTimestamps

Cool - fancy updating the PR?

[einatbar]

@johnnyreilly sure, on it

[johnnyreilly]

Awesome, do you want to update the package.json and the CHANGELOG.md? Then I think we're ready to ship!

[elf-mouse]

@einatbar , thank you very much :)

[einatbar]

@johnnyreilly Thank you! :)

[johnnyreilly]

My pleasure @einatbar !