Use custom transformer when building solution references #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to share the function between `initializeInstance` and `makeSolutionBuilderHost`. `makeSolutionBuilderHost` is called as a part of `buildSolutionReferences`. `buildSolutionReferences` is called before `initializeInstance` where the custom transformers are initialized.
This allows us to pass on the custom transformer while the project references are built.
|
Thanks for this - little snowed right now. Will look when I can |
src/servicesHost.ts
Outdated
| if (options) { | ||
| // The `configFilePath` is the same value that is used as the `project` parameter of | ||
| // `getCustomtransformers` below. | ||
| const project = options.configFilePath?.toString(); |
There was a problem hiding this comment.
is the toString necessary?
There was a problem hiding this comment.
You're right. I don't know what I was thinking. It's a string.
|
Have updated your branch - it's possible you might need to do some repairs |
`options.configFilePath` is always a string, there's no reason we need `toString()` too.
|
Failing tests following merge I'm afraid - could you take a look please? |
It started failing because the typescript compiler is complaining that options can be a bunch of different types.
|
In a previous commit, I removed `.toString()` without validating what the Typescript compiler would say. This change does a runtime check that the project variable is an actual string.
feosuna1
force-pushed
the
feo/bugfix/custom-transformer-in-build-solution
branch
from
71a8d37
to
ed3f70f
Compare
|
I think we might be nearly there. Could you update the version in the package.json and put an entry in the changeling.md please? |
johnnyreilly
approved these changes
Nov 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom transformers in project references.
While attempting to use custom transformers, I realized that the transformers were only being applied to the main target and not to any of my referenced projects. After a bit of spelunking, I found that #1025 was a similar issue to my own. #1274 attempted to solve the problem, but some changes needed to be made in Typescript to allow for custom transformers in project references. All the necessary changes to support are available in Typescript v4.3+.
I've modeled my changes after @gasnier's original PR (#1025). This change set:
getCustomTransformerslogic out ofinitializeInstanceand into a dedicated function, so that it can be shared.makeSolutionBuilderHostto include the newgetCustomTransformerfield in thesolutionBuilderHostand have it return the transformers made available in the loader options.Fixes #1025