-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Keep search in resolveReplacementExtensions #1165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 7 7
Lines 709 709
Branches 157 157
=======================================
Hits 565 565
Misses 89 89
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Thanks for sending this! It's a holiday for me so it'll be at least a few days before I review this. When I do, I'll double check that the modified line is a ts-node modification. Should be easy with a diffing tool. Also, ideally we'd have a test for this, too. I think we can add your original reproduction example to our existing ESM tests. Import the same file twice with different params and have it log a message each time. |
@cspotcode I've added a test for this. If you revert my first commit, it will fail. |
Looks good, thanks again. I'm gonna merge this, then take this as an excuse to update our copy-pasted code to the latest from node 15 in a followup PR. Then I'll publish to npm. |
Related to #1007 (comment)
The search params were lost after making a partial copy to change the file extension.
Even though the
dist-raw
is largely a copy of Node's implementation, I believe this specific line is custom ints-node
.@cspotcode Thanks for all the pointers you wrote in the comment!