Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #1956

Merged
merged 15 commits into from
Feb 13, 2023
Merged

Maintenance #1956

merged 15 commits into from
Feb 13, 2023

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Feb 12, 2023 •
edited
Loading

All internal stuff, nothing user-facing

  • extract test-lib to git dep
  • extract expect-stream / getStream to git dep
  • extract fs-fixture-builder to git dep, shared w/TypeDoc
  • get rid of lots of destructuring in tests b/c it made things less readable and less refactor-able
  • test against node 20, not 19, cuz 19 hasn't been built in a while
  • break src/test/helpers into multiple files
  • extract ctxTmpDir into context builder that also gives you an empty fixture
  • remove @yarnpkg/fslib dep
  • add hacky script to run against node nightly on linux

@cspotcode
Get rid of tons of unnecessary destructuring in tests
3f59425
@cspotcode
control in-process concurrency w/env var
8604095 
formatting in testlib
split `context` into `context` and `contextEach`; stop sprinkling `once` around
`beforeAll` -> `before`
`runIf` -> `if`
`runSerially` -> `serial`, makes `serial` overloaded
@cspotcode
extract testlib to git dep
944707e
@cspotcode
extract getStream/expectStream to git dep
484b023
@cspotcode
Replace bundled fs-fixture-builder with git dep
a27a533
@cspotcode
fix lockfile
c66eb43
@cspotcode
try to make yarn happy grrr
93e4acd
@codecov
Copy link

codecov bot commented Feb 12, 2023 •
edited
Loading

Codecov Report

Merging #1956 (b7240ba) into main (a376570) will not change coverage.
The diff coverage is n/a.

@cspotcode cspotcode marked this pull request as ready for review February 13, 2023 02:47
@cspotcode cspotcode merged commit ba741fa into main Feb 13, 2023
@cspotcode cspotcode deleted the cleanup-exec-helpers-in-tests branch February 13, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cspotcode