fix: lazy-load repl to avoid domain side effects #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspotcode
reviewed
May 23, 2023
src/repl.ts
Outdated
| // Lazy-loaded to prevent repl's require('domain') from causing problems | ||
| // https://github.com/TypeStrong/ts-node/issues/2024 | ||
| // https://github.com/nodejs/node/issues/48131 | ||
| let nodeRepl: { |
There was a problem hiding this comment.
Nit: can we simplify to let nodeRepl: typeof _nodeRepl and then nodeRepl = require('repl')? No need to explicitly enumerate the properties we use.
There was a problem hiding this comment.
That wasn't working, I think because it's exporting a namespace in @types/node, not an object.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, the * as is what I was lacking, thanks. Just doing import type nodeRepl from 'repl' is what didn't work.
Force-push updated to that, PTAL.
Codecov Report
|
Actually starting the repl will still put the process into domain-mode, but this at least allows programs to use `ts-node` or `--loader=ts-node/esm` without losing the ability to use process.setUncaughtExceptionCaptureCallback(). The problem should ideally be fixed (or mitigated) in node core, but this is still worthwhile for the benefit of supporting current node versions. Re: nodejs/node#48131 Fix: TypeStrong#2024
isaacs
force-pushed
the
isaacs/lazy-load-repl
branch
from
ba747b2 to
82789ed
Compare
cspotcode
reviewed
May 30, 2023
|
Looks great, merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually starting the repl will still put the process into domain-mode, but this at least allows programs to use
ts-nodeor--loader=ts-node/esmwithout losing the ability to use process.setUncaughtExceptionCaptureCallback().The problem should ideally be fixed (or mitigated) in node core, but this is still worthwhile for the benefit of supporting current node versions.
Re: nodejs/node#48131
Fix: #2024