unsafe re-order and make .ts > .js #649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2018
Closed
3mard
reviewed
Feb 22, 2019
src/index.ts
Outdated
| extensions.forEach(extension => { | ||
| registerExtension(extension, ignore, register, originalJsHandler) | ||
| }) | ||
| registerHanlder(opts, extensions, ignore, register, originalJsHandler) |
There was a problem hiding this comment.
Typo
Suggested change
| registerHanlder(opts, extensions, ignore, register, originalJsHandler) | |
| registerHandler(opts, extensions, ignore, register, originalJsHandler) |
3mard
reviewed
Feb 22, 2019
src/index.ts
Outdated
| /** | ||
| * unsafe re-order and make .ts > .js | ||
| */ | ||
| function registerHanlder ( |
There was a problem hiding this comment.
Typo
Suggested change
| function registerHanlder ( | |
| function registerHandler ( |
|
@blakeembrey Will this be merged ? |
|
@3mard Yes, if we refactor and add a test I'm ok merging this. |
|
@bluelovers will this be updated ? |
|
@bluelovers Can you please add some unit tests ? ( ... incase the hack became absolute ) |
|
@3mard i don't know how add a test for this |
|
This was landed in #837. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#648