doc: add precision regarding --files option
#930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspotcode
reviewed
Jan 3, 2020
README.md
Outdated
| @@ -215,7 +215,7 @@ An alternative approach for definitions of third-party libraries are [triple-sla | |||
| import UntypedJsLib from "untyped_js_lib" | |||
| ``` | |||
|
|
|||
| **Tip:** If you _must_ use `files`, enable `--files` flags or set `TS_NODE_FILES=true`. | |||
| **Tip:** If you _must_ use `files` or `include`/`exclude`, enable `--files` flags or set `TS_NODE_FILES=true`. | |||
There was a problem hiding this comment.
Nit: how about this phrasing, since some people combine "files" with "include"?
If you must use
files,include, orexclude, enable ...
There was a problem hiding this comment.
Thanks, done. Also reworded the phrase above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to add a little precision about
--filesoptions, since it does not seem very clear #782 (comment)