-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ts node script #948
Merged
cspotcode
merged 11 commits into
TypeStrong:master
from
G-Rath:deprecate-ts-node-script
Feb 15, 2020
Merged
Deprecate ts node script #948
cspotcode
merged 11 commits into
TypeStrong:master
from
G-Rath:deprecate-ts-node-script
Feb 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
approved these changes
Jan 25, 2020
package.json
Outdated
@@ -6,7 +6,9 @@ | |||
"types": "dist/index.d.ts", | |||
"bin": { | |||
"ts-node": "dist/bin.js", | |||
"ts-script": "dist/script.js" | |||
"ts-script": "dist/script-deprecated.js", | |||
"ts-node-script": "dist/script.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Let's move to bin-*.js
to clarify intent, but LGTM.
This was referenced Mar 18, 2020
This was referenced Mar 26, 2020
This was referenced Apr 12, 2020
This was referenced Apr 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #939, this deprecated
ts-script
in favor ofts-node-script
.(I've based this off #939 to avoid a merge conflict, so this should be merged after that PR is merged).