Implement getProjectVersion #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
approved these changes
Feb 25, 2020
| if (!isFileInCache) { | ||
| rootFileNames.push(fileName) | ||
| // Modifying rootFileNames means a project change | ||
| shouldIncrementProjectVersion = true |
There was a problem hiding this comment.
Nit: You could just do projectVersion++ here - it's essentially the same, an extra +1 every now and then isn't a big deal.
src/index.ts
Outdated
| @@ -469,6 +470,7 @@ export function create (rawOptions: CreateOptions = {}): Register { | |||
|
|
|||
| // Create the compiler host for type checking. | |||
| const serviceHost: _ts.LanguageServiceHost = { | |||
| getProjectVersion: () => `${ projectVersion }`, | |||
There was a problem hiding this comment.
Nit: Personally I'd just do String(projectVersion) since you just want to type cast.
Yeah, I wasn't sure about that. I really wanted to avoid ts-node crashing if new versions of the TypeScript compiler misbehaved. I figured better for us to remain functional with degraded performance and let the debug logs point out why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to microsoft/TypeScript#36748, TypeScript's language service always thinks the
Programis out-of-date and rebuilds it 3 times for every.tsfile that we load: once each forgetEmitOutput,getSemanticDiagnostics, andgetSyntacticDiagnostics.We can workaround this bug by implementing
getProjectVersion. IfgetProjectVersionstays the same, TypeScript will reuse the existingProgram. It'll still need to be rebuilt every time we modify the rootFiles array, but that's only once instead of 3 times.I also added debug log statements that double-check when the
Programinstance is rebuilt. This should be helpful if we ask for TS_NODE_DEBUG logs from users.