Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define MVP #1

Open
keithlayne opened this issue Jul 13, 2021 · 13 comments
Open

Define MVP #1

keithlayne opened this issue Jul 13, 2021 · 13 comments

Comments

@keithlayne
Copy link
Collaborator

keithlayne commented Jul 13, 2021

What are the immediate goals?

Trying to sum up what was discussed on discord:

  • Use ghpages for POC
  • Have a periodic GH action that works off of some kind of work queue to build pages

Talked about:

  • Limiting scope initially to a subset of npm
  • Maybe ignore cross-linking for now
@cspotcode
Copy link
Collaborator

I invited you to be a maintainer of this repository. I added some MVP stuff to the readme, but feel free to delete what I wrote and instead link to this issue.

@cspotcode
Copy link
Collaborator

I copy-pasted a nightly GH Actions runner from another project, hopefully to serve as inspiration for anyone who might want to attempt an implementation.

@cspotcode
Copy link
Collaborator

Should we mention "typedoc" explicitly since the choice of documentation tool has been a question on Discord?

@tjjfvi
Copy link

tjjfvi commented Jul 13, 2021

Should we mention "typedoc" explicitly since the choice of documentation tool has been a question on Discord?

I mean, the repo is named typedoc-auto-docs

@cspotcode
Copy link
Collaborator

Haha, point taken.

@keithlayne
Copy link
Collaborator Author

I was slow and my issue is way less useful than the readme.

I haven't done much with ghpages, I thought there were multiple options for how to set it up in addition to a dedicated branch, but that's all I see in the settings. Who has experience with that? I assume like on the comment in the workflow file we'll need to build and push to the docs branch?

@tjjfvi
Copy link

tjjfvi commented Jul 13, 2021

I've used peaceiris/actions-gh-pages in the past, and it's been rather nice

@cspotcode
Copy link
Collaborator

I have a bunch of experience with ghpages. Admittedly that may make me biased.

There are multiple options. The one I always use -- for no particular reason -- is the gh-pages branch. Any files pushed to the gh-pages branch are served as a static site. This means you can use whatever git commands you want to push static files into that branch. You can choose to commit changes to single directories, you can choose to force-push and replace the entire thing, whatever is the easiest.

@keithlayne
Copy link
Collaborator Author

yeah, I forgot. I realized that you can pick a path after you pick a branch. Do you keep history on your gh-pages branch? Force-pushing sounds pretty reasonable for something like this.

@cspotcode
Copy link
Collaborator

I don't think history is important. However if we want our worker script to build and push docs for a single library at once, this may mean it is easiest to commit changes to a single subdirectory at a time.

For example, for an MVP our worker script might be doing something like this:

cd gh-pages-subdirectory
git checkout gh-pages
cp ../some-docs-rendered-here './libA@semver-range'
git add './libA@semver-range'
git commit -m "Adding rendered docs for libA@semver-range"
git push

@cspotcode
Copy link
Collaborator

We might be able to use some slick git commands in the future to avoid checking out the full gh-pages branch, since it will get big. And in the future future we can replace these git commands with aws s3 push or something like that

@keithlayne
Copy link
Collaborator Author

Yeah I was thinking shallow clone, update, force push. I was also thinking that the script would hit the npm (or whatever) API to see if each lib is out of date, then just build each as needed. But simpler is better.

Your way simplifies several things too.

@cspotcode
Copy link
Collaborator

cspotcode commented Jul 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants