Skip to content

Commit

Permalink
Fix even more packages bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
Gerrit0 committed Jun 22, 2024
1 parent 60a262d commit 6ef1053
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
- Fixed an issue with packages mode where TypeDoc would use (much) more memory than required, #2607.
- TypeDoc will no longer crash when asked to render highlighted code for an unsupported language, #2609.
- Fixed an issue where relatively-linked files would not be copied to the output directory in packages mode.
- Fixed an issue where modifier tags were not applied to top level modules in packages mode.
- Fixed an issue where excluded tags were not removed from top level modules in packages mode.
- `.jsonc` configuration files are now properly read as JSONC, rather than being passed to `require`.

### Thanks!
Expand Down
10 changes: 7 additions & 3 deletions src/lib/converter/plugins/CommentPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,8 @@ export class CommentPlugin extends ConverterComponent {

if (
reflection.kindOf(
ReflectionKind.Module | ReflectionKind.Namespace,
) ||
reflection.kind === ReflectionKind.Project
ReflectionKind.Project | ReflectionKind.SomeModule,
)
) {
comment.removeTags("@module");
comment.removeModifier("@packageDocumentation");
Expand Down Expand Up @@ -317,6 +316,11 @@ export class CommentPlugin extends ConverterComponent {
* @param context The context object describing the current state the converter is in.
*/
private onBeginResolve(context: Context) {
if (context.project.comment) {
this.applyModifiers(context.project, context.project.comment);
this.removeExcludedTags(context.project.comment);
}

const project = context.project;
const reflections = Object.values(project.reflections);

Expand Down

0 comments on commit 6ef1053

Please sign in to comment.