Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Closes #1628 by lowering node engines to 12.10 #1632

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

betaorbust
Copy link
Contributor

This PR partially addresses #1628 by opening up the engines requirement back to Node 12.10.

Lower than 12.10 would require refactoring src/lib/utils/fs.ts to use something other than fs.rmdir({ recursive: true }), which was introduced in 12.10

Lower than 12.10 would require refactoring src/lib/utils/fs.ts to use something other than fs.rmdir({ recursive: true }), which was introduced in 12.10 https://nodejs.org/docs/latest-v12.x/api/fs.html#fs_fs_rmdir_path_options_callback
@Gerrit0 Gerrit0 merged commit 8f6992a into TypeStrong:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants