-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Readonly" flag for readonly properties #623
Conversation
…ctory - Added a reflection flag for readonly properties - Moved the abstract flag assignment to declaration factory, fixes the issue that abstract accessors were not considered before
Recently introduced Const flag is added to const enumerations
Const flag is added to const enumerations. |
Thanks for the PR. This would close #585 assuming it is also added to the default themes |
@makana When creating the UI it's easier as well, you want to show readonly on classes and const on variables and if they are consolidated you have to do some logic which is not optimal. It's better to stick to the same path as TS and not create local terminology... |
@shlomiassaf @aciccarello |
#1268 made these changes and has been merged in. |
Readonly reflection flag for readonly properties is added.
This PR is related to #611
The way, the abstract flag is added to the reflection is changed. It fixes the issue that abstract accessors weren't considered so far.
To extend the discusson on #611:
Does it make sense to remove the Const flag in favor of the Readonly flag?