Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update marked dependency #675

Closed

Conversation

craigmichaelmartin
Copy link

Thanks for this great tool!

Purpose: This PR updates the marked dependency by bumping its patch version.

Background: marked@0.3.6 has two security vulnerabilities (https://nvd.nist.gov/vuln/detail/CVE-2017-1000427, https://nvd.nist.gov/vuln/detail/CVE-2017-17461). While these are not exposed given how typedoc uses marked - the vulnerability warning is passed through to all repos that depend on typedoc. This creates a burden of keeping track of what vulnerabilities are actual - and desensitizes the github tool.


It is unclear why files beyond package.json changed. I noticed the same changes simply by cloning the repo and installing - so they don't seem related to this PR. If you'd like me to remove them from this PR, I'd be happy. Just let me know!

@aciccarello
Copy link
Collaborator

Thanks for the PR @craigmichaelmartin. The test files need to be updated from another change so that's why they showed up. I need to go through and update various other dependencies so I may do this change in a separate commit but I appreciate knowing that there are vulnerability warnings coming through.

@jeremyhaile
Copy link

Please merge and release. Trying to remove as a security vulnerability from our project. Thanks!

@aciccarello aciccarello self-assigned this Jan 23, 2018
@sallar
Copy link

sallar commented Jan 29, 2018

Is there something preventing this from being merged? Security issues are not a small thing. Please kindly merge this :) Thank you.

aciccarello added a commit that referenced this pull request Feb 1, 2018
closes #675
closes #679
closes #680
@chriskrycho
Copy link

Thanks for merging this. Please ship a release post-haste!

@aciccarello
Copy link
Collaborator

@chriskrycho this should be included in the 0.10.0 release. Another release is needed to fix an issue with the exclude not exported flag

@chriskrycho
Copy link

Hmm. I just updated to 0.10.0, and that's when GitHub flagged up the issue. 🤔

@aciccarello
Copy link
Collaborator

Interesting. Looks like all versions of marked have a Regex DOS vulnerability. See markedjs/marked#1039 for more details. We can update when a fix is issued.

For reference, marked should currently be at version ^0.3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants