Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release triggered by tags instead of release #68

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

vv-monsalve
Copy link
Collaborator

@simoncozens this PR changes the release condition to be triggered by the tags instead.
Please let me know if this would be enough or if something else would be needed here :)

@simoncozens
Copy link
Collaborator

It would also need to create the release. From the googlefonts-project-template:

      - name: Check for release
        id: create_release
        run: |
          if ! gh release view ${{ github.ref_name }}; then
          git show -s --format=%B ${{ github.ref_name }} | tail -n +4 | gh release create ${{ github.ref_name }} -t ${{ github.ref_name }} -F -
          fi

@vv-monsalve
Copy link
Collaborator Author

Updated!

Copy link
Collaborator

@simoncozens simoncozens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vv-monsalve
Copy link
Collaborator Author

Ty!

@vv-monsalve vv-monsalve merged commit 5f6fb86 into main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants