added get_latest_tag in install.sh #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Updated install.sh to fetch the latest version from the git hub instead of hard coding. 2. Updated RELEASE.md file.
Chemaclass
reviewed
Mar 10, 2024
| @@ -2,13 +2,23 @@ | |||
|
|
|||
| # shellcheck disable=SC2164 | |||
| # shellcheck disable=SC2103 | |||
| declare -r BASHUNIT_GIT_REPO="https://github.com/TypedDevs/bashunit" | |||
|
|
|||
| function get_latest_tag() { | |||
There was a problem hiding this comment.
Can you write a test to ensure the behaviour of this new function?
There was a problem hiding this comment.
I am using the existing function for the latest update;
A test case already exists to test the function test_get_latest_tag() in \bashunit\tests\unit\helpers_test.sh.
There was a problem hiding this comment.
For acceptance tests,
we have a function called test_install_downloads_the_latest_version() in tests\acceptance\install_test.sh, which does the same, and it passed when I tested locally after changes.
Please let me know if you want something else.
There was a problem hiding this comment.
You are right, that test is covering that area as well, thanks!
Chemaclass
approved these changes
Mar 13, 2024
antonio-gg-dev
approved these changes
Mar 13, 2024
|
Closes #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Remove downtime on install latest #225
🔖 Changes
Updated install.sh to fetch the latest version from the git hub instead of hard coding.
Updated RELEASE.md file.