Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added get_latest_tag in install.sh #248

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

maheshmeleti
Copy link
Contributor

📚 Description

Remove downtime on install latest #225

🔖 Changes

  1. Updated install.sh to fetch the latest version from the git hub instead of hard coding.

  2. Updated RELEASE.md file.

1. Updated install.sh to fetch the latest version from the git hub instead of hard coding.

2. Updated RELEASE.md file.
Copy link
Member

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Although, I am missing some tests for this new logic. Some ideas: an acceptance test to make sure the whole thing works as expected, and/or a unit test for the new little function behaviour.

@@ -2,13 +2,23 @@

# shellcheck disable=SC2164
# shellcheck disable=SC2103
declare -r BASHUNIT_GIT_REPO="https://github.com/TypedDevs/bashunit"

function get_latest_tag() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a test to ensure the behaviour of this new function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using the existing function for the latest update;
A test case already exists to test the function test_get_latest_tag() in \bashunit\tests\unit\helpers_test.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For acceptance tests,
we have a function called test_install_downloads_the_latest_version() in tests\acceptance\install_test.sh, which does the same, and it passed when I tested locally after changes.

Please let me know if you want something else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, that test is covering that area as well, thanks!

@Chemaclass Chemaclass added the enhancement New feature or request label Mar 10, 2024
Copy link
Member

@khru khru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@antonio-gg-dev
Copy link
Member

Closes #225

@antonio-gg-dev antonio-gg-dev linked an issue Mar 13, 2024 that may be closed by this pull request
@Chemaclass Chemaclass merged commit 675fd42 into TypedDevs:main Mar 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove downtime on install latest
4 participants