chore: add fail() function #249
Conversation
There was a problem hiding this comment.
How interesting. Is this something you have seen in other libraries, @ceejatec?
docs/assertions.md
Outdated
| function test_failure() { | ||
| [ $(date +%-H) -lt 6 ] || fail "It's late, go to bed" | ||
| } |
There was a problem hiding this comment.
The example you set for test_failure doesn't always fail because it depends on the time of execution. The idea is to have one of the examples always succeed and the other always fail. Could you change it?
I think it would also help to use the if syntax instead of the || operator in both examples, as it's more familiar to a greater number of programmers.
There was a problem hiding this comment.
I've modified them as requested. I had trouble coming up with an example that could seem useful in only a line or two, but I think this gets the job done.
|
@Chemaclass Indeed, it's a pretty common function, going right back to JUnit. IME, frequently the various assert() methods are internally implemented in terms of the basic |
📚 Description
Adds new
fail()function for general purpose test failures not covered by the variousassert_*functions.🔖 Changes
fail()function in assert.shconsole_results::print_failure_message()function in console_results.sh✅ To-do list
CHANGELOG.mdto reflect the new feature or fix