Merge pull request xtermjs#5253 from akphi/patch-1

bug: properly render the terminal when open() is called again
Tyriar · Jan 6, 2025 · 601efc3 · 601efc3
2 parents af4208d + 62656b8
commit 601efc3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/browser/CoreBrowserTerminal.ts b/src/browser/CoreBrowserTerminal.ts
@@ -400,7 +400,7 @@ export class CoreBrowserTerminal extends CoreTerminal implements ITerminal {
     }
 
     // If the terminal is already opened
-    if (this.element?.ownerDocument.defaultView && this._coreBrowserService) {
+    if (this.element?.ownerDocument.defaultView && this._coreBrowserService && this.element?.isConnected) {
       // Adjust the window if needed
       if (this.element.ownerDocument.defaultView !== this._coreBrowserService.window) {
         this._coreBrowserService.window = this.element.ownerDocument.defaultView;