v4.3.1 update #809

Tzahi12345 · 2023-01-03T07:41:05Z

Looks ready for release, leaving this up for a couple days before merging! See details below:

Major UI overhaul (see screenshot below)
- Updating to Angular v15 came with Angular Material v15 support, which changed the look of many components. We can revert this if needed, but I do like it a lot more
- Removed title from the top toolbar, added an icon which will take you home
- Removed the blue color from the toolbar
- Moved filters to the top, and made them "chips" (see demo below)
- Lots of other small UI improvements
Added notifications support
- 3 types (for now)
  - Download complete
  - Download error
  - Task finished
- You can enable or disable notifications types to avoid spam
- Gotify, ntfy, and Telegram are also supported out of the box (closes [FEATURE] Webhook integration to inform other applications and users when Download is finished #440, closes [FEATURE] Connect with other apps for notification #783)
Archive system overhaul (closes [BUG] downloader.js should use node-file-dedup instead of merge-files #756, closes [BUG] Archive/Merged.txt files grow to ludicrous size #777)
- Archives are now handled internally and its functionality is simulated. This is to avoid having to write to archive files
- New (per-user) archive viewer added to manage/export archives
Added task to delete old files (closes Auto delete old files #358)
- Added settings for tasks
Converted allow autoplay to force autoplay (closes Force autoplay #695)
Added ability to favorite/unfavorite videos -- and you can filter for them too!
Fixed issue where subscriptions would continue downloading its videos after unsubscription (closes [BUG] videos are still downloaded after removing subscription #689)
- Note that this doesn't completely fix the issue as we can't stop a download once it actually begins, but now we catch it before
Approximate file sizes now displayed as tooltips in the quality select menu (closes [FEATURE] Pre-Download File Size #838)
Fixed issue with timezones and task scheduling (closes [BUG] Scheduling Recurring Task not accounting for container time-zone #810)
Fixed an issue causing logins to fail in multi-user mode (closes [BUG] Can't Login in with Multiuser mode (Login Failed - Unknown Error) #813)
Fixed an issue where only 10 subscription videos would appear in the subscription page (closes [BUG] After updating the docker image, most videos do not display #851)
RSS feed for downloads (closes [FEATURE] RSS feed for all downloads #388)
Updated Angular, Angular Material, and other dependencies
Workspace improvements (vscode specific)

New UI:

New filters demo:

YoutubeDL-Material.-.Google.Chrome.2023-01-03.02-31-48.-.Trim.mp4

Notifications:

Expanded widths of inputs on login page to 100%

Minor code cleanup

Style improvements

…e canActivate would be executed

Various style improvements Updated translations

…s made to args

Moved file filter options above the list of files, and added option to filter for favorites

- removed title - added logo which navigates users home - removed blue color

Added notifications for tasks

Added support for task errors Added support for lt, gt etc. db comparisons Added task to delete old files

Improved translation coverage

Code cleanup

…(currently unused)

BillSobel · 2023-01-31T01:43:17Z

Here is an example channel that crashes the app by causing the runaway download issue (memory goes up to the max, then the app crashes and restarts)

https://www.youtube.com/@joeeasygo

Began UI for viewing/modifying archives

Added archive importing

backend/app.js

@@ -1526,20 +1511,69 @@
    });
 });

+app.post('/api/getArchives', optionalJwt, async (req, res) => {


backend/app.js

    }

 });

+app.post('/api/importArchive', optionalJwt, async (req, res) => {


backend/app.js

+    });
+});
+
+app.post('/api/deleteArchiveItems', optionalJwt, async (req, res) => {


backend/app.js

+app.post('/api/deleteArchiveItems', optionalJwt, async (req, res) => {
+    const uuid = req.isAuthenticated() ? req.user.uid : null;
+    const archives = req.body.archives;
+
+    let success = true;
+    for (const archive of archives) {
+        success &= await archive_api.removeFromArchive(archive['extractor'], archive['id'], archive['type'], uuid, archive['sub_id']);
+    }
+
+    res.send({
+        success: success
+    });
+});


backend/app.js

+app.post('/api/getArchives', optionalJwt, async (req, res) => {
+    const uuid = req.isAuthenticated() ? req.user.uid : null;
+    const sub_id = req.body.sub_id;
+    const filter_obj = {user_uid: uuid, sub_id: sub_id};
+    const type = req.body.type;
+
+    // we do this for file types because if type is null, that means get files of all types
+    if (type) filter_obj['type'] = type;
+
+    const archives = await db_api.getRecords('archives', filter_obj);
+
+    res.send({
+        archives: archives
+    });
+});


backend/app.js

+app.post('/api/importArchive', optionalJwt, async (req, res) => {
+    const uuid = req.isAuthenticated() ? req.user.uid : null;
+    const archive = req.body.archive;
+    const sub_id = req.body.sub_id; 
+    const type = req.body.type;
+
+    const archive_text = Buffer.from(archive.split(',')[1], 'base64').toString();
+
+    const imported_count = await archive_api.importArchiveFile(archive_text, type, uuid, sub_id);
+
+    res.send({
+        success: !!imported_count,
+        imported_count: imported_count
+    });
+});


Fixed minor notification crash

…r than disappearing

backend/app.js

 app.post('/api/downloadArchive', optionalJwt, async (req, res) => {
-    let sub = req.body.sub;
-    let archive_dir = sub.archive;
+    const uuid = req.isAuthenticated() ? req.user.uid : null;
+    const sub_id = req.body.sub_id; 
+    const type = req.body.type;

-    let full_archive_path = path.join(archive_dir, 'archive.txt');
+    const archive_text = await archive_api.generateArchive(type, uuid, sub_id);

-    if (await fs.pathExists(full_archive_path)) {
-        res.sendFile(full_archive_path);
+    if (archive_text !== null && archive_text !== undefined) {
+        res.setHeader('Content-type', "application/octet-stream");
+        res.setHeader('Content-disposition', 'attachment; filename=archive.txt');
+        res.send(archive_text);
    } else {
-        res.sendStatus(404);
+        res.sendStatus(400);
+    }
+
+});


…rial into notifications-update

…crash (#813)

…e subscription component (#851) Fixed an issue where a sub would get stuck in the downloading state Fixed UI bug in the subscriptions component

Tzahi12345 and others added 30 commits July 6, 2022 23:31

Login tabs now fill the entire component

1c6b781

Expanded widths of inputs on login page to 100%

Added notifications - (WIP, boilerplate)

5e08ca0

Angular updated to v14

49ecaee

Updated angular material to v14

b1c213f

Updated ngx-avatars

790db77

Updated angular to v15

6d5a108

Fixed compilation error

4583e3e

Completed notification functionality

b51f45c

Minor code cleanup

Added support for download error notifications

f44be29

Style improvements

Minor notification style improvement

3795a65

Updated to material design v15

b11a4e0

Fixed bug where sometimes the config wouldn't be retrieved by the tim…

5a6e17e

…e canActivate would be executed

Converted input placeholders to mat-label

0efbd11

Various style improvements Updated translations

Added timestamp to notifications

ac808fc

Fixed issue where simulated output would only appear after a change i…

20e7ec7

…s made to args

Style improvements and UI bug fixes

c45e0f0

Added ability to favorite a file

665bcc0

Moved file filter options above the list of files, and added option to filter for favorites

Updated style of top toolbar

2860b45

- removed title - added logo which navigates users home - removed blue color

Unused code cleanup

992947f

Notifications style improvements

cc2be46

Misc style improvements and code cleanup

1d10d36

Dependencies update

bfcc6a0

Added filters for notifications

4f26e9a

Added notifications for tasks

Fixed potential UI bug where notifications menu would be too small

964760a

Fixed issue where role/user permissions could not be changed

0cf9f2d

Updated vscode tasks

3edd4ec

Added task settings

46756a5

Added support for task errors Added support for lt, gt etc. db comparisons Added task to delete old files

Minor tests cleanup and workspace improvements

6d881dc

Added nfty and gotify notifications support

f0c9a61

Fixed UI console error

7d1c5ff

Tzahi12345 added 4 commits January 24, 2023 21:45

UI updates to subscriptions

970e383

Improved translation coverage

Unsubscribing now deletes entries from the archive

e82066b

Code cleanup

Enabled strict template mode in Angular

6010d99

Code cleanup

Added download error type information to notifications and downloads …

0f7c495

…(currently unused)

Tzahi12345 and others added 5 commits March 20, 2023 20:23

Added telegram notification support

cb5651d

Updated OpenAPI version

a2b5484

Archive improvements

62ad422

Began UI for viewing/modifying archives

Reverted changes to generated openapi types

77a858e

Improved archive viewer

c1fd804

Added archive importing

github-advanced-security bot found potential problems Mar 27, 2023

View reviewed changes

Tzahi12345 added 3 commits March 27, 2023 18:32

Filter text in archive viewer now resets when changing other filters

9c4f903

Download notifications now include original URL

07a0ea6

Fixed minor notification crash

Downloads restarted from home page now persist after restarting rathe…

0bdac15

…r than disappearing

github-advanced-security bot found potential problems Mar 27, 2023

View reviewed changes

Updated translations source file

a4bbc7d

Tzahi12345 marked this pull request as ready for review March 27, 2023 23:45

Merge branch 'master' of https://github.com/Tzahi12345/YoutubeDL-Mate…

b911552

…rial into notifications-update

Tzahi12345 mentioned this pull request Mar 31, 2023

[BUG] Archive/Merged.txt files grow to ludicrous size #777

Closed

Tzahi12345 added 2 commits April 1, 2023 00:15

Added filesize approximation tooltips to quality select

a9d7f27

Removed deprecated safe_download_override setting

0e15fd7

Tzahi12345 mentioned this pull request Apr 1, 2023

[FEATURE] Pre-Download File Size #838

Closed

Tzahi12345 added 2 commits April 1, 2023 03:14

Added ability to download archives from the archive viewer

763ce5d

Fixed an issue where JWT_EXPIRATION was sometimes a string causing a …

9f833d3

…crash (#813)

Tzahi12345 mentioned this pull request Apr 1, 2023

[BUG] Can't Login in with Multiuser mode (Login Failed - Unknown Error) #813

Closed

Fixed an issue where subs would only display 10 of their videos in th…

1f2c5a0

…e subscription component (#851) Fixed an issue where a sub would get stuck in the downloading state Fixed UI bug in the subscriptions component

Tzahi12345 mentioned this pull request Apr 1, 2023

[BUG] After updating the docker image, most videos do not display #851

Closed

Tzahi12345 merged commit 929e01e into master Apr 1, 2023

This was referenced Apr 8, 2023

[FEATURE] Add ability to browse individual subscriptions #845

Closed

[BUG] removeIDFromArchive leaves duplicate entries #755

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v4.3.1 update #809

v4.3.1 update #809

Tzahi12345 commented Jan 3, 2023 •

edited

Loading

BillSobel commented Jan 31, 2023

v4.3.1 update #809

v4.3.1 update #809

Conversation

Tzahi12345 commented Jan 3, 2023 • edited Loading

BillSobel commented Jan 31, 2023

Tzahi12345 commented Jan 3, 2023 •

edited

Loading