Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#184 / [초대코드공유] 버튼 마진값 조정 #185

Merged
merged 3 commits into from
Dec 29, 2023
Merged

#184 / [초대코드공유] 버튼 마진값 조정 #185

merged 3 commits into from
Dec 29, 2023

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Dec 28, 2023

📌 관련 이슈

📷 screenshot

📝 Work Desciption

  • button 높이 dimen으로 빼기
  • 버튼 마진값 조정

📚 Reference 혹은 궁금한 사항들

앱잼 때 기존 마진 값이 너무 작아 논의 후 조정했는데, 기기 대응 이슈로 다시 복구했습니다~!

@taeheeL taeheeL added fix 버그 수 UI UI 작업 태희 🦊 유니의 대장 담당 labels Dec 28, 2023
@taeheeL taeheeL requested a review from a team December 28, 2023 13:06
@taeheeL taeheeL self-assigned this Dec 28, 2023
l2zh
l2zh approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@l2zh l2zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shout out to 우리 아빠

@taeheeL taeheeL merged commit 9ffbfe7 into develop Dec 29, 2023
1 check passed
@taeheeL taeheeL deleted the fix/#184-share-invite-code-constraint branch December 30, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2zh l2zh l2zh approved these changes

Assignees

@taeheeL taeheeL

Labels
fix 버그 수 태희 🦊 유니의 대장 담당 UI UI 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[초대코드공유] 제약 재설정
2 participants
@taeheeL @l2zh