JavaScript cleanup #421
JavaScript cleanup #421
Conversation
eddieantonio
added
Improvement
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
@eddieantonio why shouldn't we use jquery |
It's one more dependency that we don't really need when we're doing DOM manipulation that can be done without jQuery. Do the same with a lot less code! |
| } | ||
|
|
||
| /** | ||
| * use xhttp to load search results in place | ||
| * use AJAX to load search results in place |
There was a problem hiding this comment.
@eddieantonio why is ajax favoured over xhttp?
There was a problem hiding this comment.
AJAX refers to any asynchronous HTTP request, whether it's done with the crusty old XMLHttpRequest API or the newer, less error-prone fetch() API.
There was a problem hiding this comment.
aah was asking why use fetch over XMLHttpRequest
There was a problem hiding this comment.
aah was asking why use fetch over XMLHttpRequest
I've personally always went with XMLHttpRequest because it's what I was taught/learned first! Fetch is new to me but I'm aware that it is the future so I'll try to work at using it more go forward.
If I remember right, fetch handles some things better than XMLHttpRequest does (did?). I think I have a short tutorial tucked away for why the newer is better: just holler and I can pull it over the weekend or something 💪
This is a series of refactors, style tweaks, and changes, including:
fetch()consistently instead ofXMLHTTPRequestI mostly worked on
index.js, not really doing anything more than running ESLint onrecordings.js.EDIT: one casualty is waiting for the
fetch()in our loading bar tests because Cypress doesn't currently supportfetch()BUT, they're working on it!