feat:Updates forecast function output to 3 columns

BREAKING CHANGE: Forecast function now retuns a facet plot with 3 columns
UBC-MDS · Jan 29, 2022 · 14a91d6 · 14a91d6
1 parent 08c203c
commit 14a91d6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/src/airpyllution/airpyllution.py b/src/airpyllution/airpyllution.py
@@ -288,8 +288,8 @@ def get_pollution_forecast(lat, lon, api_key):
                     y=alt.Y("Concentration", title="Concentration"),
                     color=alt.Color("Pollutants"),
                 )
-                .properties(width=180, height=180)
-                .facet(facet="Pollutants:N", columns=4)
+                .properties(width=100, height=100)
+                .facet(facet="Pollutants:N", columns=3)
                 .resolve_axis(x="independent", y="independent")
                 .resolve_scale(x="independent", y="independent")
                 .properties(

diff --git a/tests/test_airpyllution.py b/tests/test_airpyllution.py
@@ -69,13 +69,7 @@ def json(self):
             return "ERROR"
         return MockResponse(mock_forecast_data, 200)
 
-    return MockResponse(
-        {
-            "cod": 401,
-            "message": mock_invalid_message,
-        },
-        404,
-    )
+    return MockResponse({"cod": 401, "message": mock_invalid_message,}, 404,)
 
 
 @patch("requests.get", side_effect=mocked_requests_get_pollution)
@@ -219,9 +213,7 @@ def test_air_pollution(mock_api_call):
     # API error
     assert (
         airpyllution.get_air_pollution(
-            mock_params["lat"],
-            mock_params["lon"],
-            mock_error_params["appid"],
+            mock_params["lat"], mock_params["lon"], mock_error_params["appid"],
         )
         == "An error occurred requesting data from the API"
     )
@@ -311,9 +303,7 @@ def test_pollution_forecast(mock_api_call):
 
     assert (
         airpyllution.get_pollution_forecast(
-            mock_params["lat"],
-            mock_params["lon"],
-            mock_error_params["appid"],
+            mock_params["lat"], mock_params["lon"], mock_error_params["appid"],
         )
         == "An error occurred requesting data from the API"
     )
@@ -332,7 +322,7 @@ def test_pollution_forecast(mock_api_call):
         mock_params["lat"], mock_params["lon"], mock_params["appid"]
     )
 
-    assert forecast_chart.columns == 4
+    assert forecast_chart.columns == 3
     assert len(forecast_chart.data) > 2
     assert len(forecast_chart.data) == 16
     assert (