Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to bookmark game events in Thunderscope replay logs #3355

Open
1 task
itsarune opened this issue Oct 12, 2024 · 0 comments · May be fixed by #3418
Open
1 task

Add ability to bookmark game events in Thunderscope replay logs #3355

itsarune opened this issue Oct 12, 2024 · 0 comments · May be fixed by #3418
Assignees
Labels
Difficulty - 13 Require a good understanding of relevant systems and tools, and may require some pathfinding Thunderscope

Comments

@itsarune
Copy link
Contributor

Description of the task

Thunderscope automatically logs all messages to /tmp/tbots/. We can replay these logs using ./tbots.py run thunderscope_main --blue_log /tmp/tbots/blue/{protolog folder}.

When we actually play a game at Robocup, a 10 minute game can balloon up to 60+ minutes because of stoppages in play and it makes it really hard to review these logs.

Add the ability to "bookmark" events and add a way to jump to these bookmarks in the Thunderscope replay window.

Possible approach:

  1. Add a button to the field widget toolbar to add game "bookmarks"
  2. Pressing this button should send a new type of proto ReplayBookmark proto that contains the timestamp
  3. ProtoPlayer should be preprocess the replay and find the ReplayBookmark protos
  4. Add a button to the [ReplayControls widget](https://github.com/UBC-Thunderbots/Software/blob/master/src/software/thunderscope/replay/replay_controls.py) to jump to the next ReplayBookmark timestamp

Acceptance criteria

  • Manual testing: We should be able to run Thunderscope with AI vs AI and place various bookmarks. Then, re-run the replay for the AI vs AI and jump to the various bookmarks

Blocked By

@itsarune itsarune added Difficulty - 13 Require a good understanding of relevant systems and tools, and may require some pathfinding Thunderscope labels Oct 12, 2024
@Lmh-java Lmh-java self-assigned this Nov 10, 2024
@Lmh-java Lmh-java linked a pull request Jan 7, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty - 13 Require a good understanding of relevant systems and tools, and may require some pathfinding Thunderscope
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants