Add bookmark system & Integrate toast message into thunderscope #3418
Conversation
Lmh-java
requested review from
itsarune,
williamckha and
sauravbanna
as code owners
itsarune
requested review from
a team,
Andrewyx and
AmyKawa
and removed request for
a team
| for marker in self.bookmarks_markers: | ||
| marker.update() | ||
|
|
||
| def resizeEvent(self, a0): |
| timestamp=Timestamp(epoch_timestamp_seconds=timestamp) | ||
| ) | ||
| self.proto_unix_io.send_proto(ReplayBookmark, bookmark) | ||
| QMessageBox.information(self, "Bookmark", "Added Bookmark") |
There was a problem hiding this comment.
a toast message would be cool: https://pypi.org/project/pyqt-toast-notification/
If it's not easy to do this or you don't want to do it, you can make an issue and ignore this comment
There was a problem hiding this comment.
Yes, I was thinking about this. I am happy to integrate this into our project.
There was a problem hiding this comment.
Added this dependecy and implemented a few helpers for future usage
|
Lmh-java
changed the title
|
Upgraded PyQt6-Qt from 6.6.1 to 6.8.1 to resolve conflicts. |
|
|
||
|
|
||
| def show_toast( | ||
| parent: QWidget, title: str, text: str, timeout: int, preset: ToastPreset |
There was a problem hiding this comment.
| parent: QWidget, title: str, text: str, timeout: int, preset: ToastPreset | |
| parent: QWidget, title: str, text: str, timeout_ms: int, preset: ToastPreset |
suffixing the _ms makes the code self-documenting
There was a problem hiding this comment.
- for all the other functions in this file
|
LGTM so far, I haven't had a chance to manually test it. But there are some small nits. I did not label all of them but just some so you watch for return types. |
| # Re-calculate the position of the visuals | ||
| slider_rect: QRect = self.slider.geometry() | ||
| max_val = self.slider.maximum() / MILLISECONDS_PER_SECOND | ||
| self.move(int(slider_rect.width() * self.value // max_val), 42) |
There was a problem hiding this comment.
what does move do on a QPushButton?
also what's 42 referring to
There was a problem hiding this comment.
seems like a magic number (which should be a constant):
Software/docs/code-style-guide.md
Line 72 in cedb04f
There was a problem hiding this comment.
lol, this is indeed a magic number. I will try to come up with another more dynamic way to calculate this. If I can't I will use a constant instead.
There was a problem hiding this comment.
This moves the bookmark visual to the right place dynamically (if we resize the window, the bookmark should be roughly at the right position on the progress bar.
There was a problem hiding this comment.
I was trying to use a relative positioning system, but the x-coord of the bookmark is dynamically computed, and I don't think we can use absolute position for x-coord while using relative position for y-coord. So I used move to do absolute positioning.
Description
This PR introduces a bookmark system, which allows user to add bookmark to a point of interest.
This PR also integrates toast message into thunderscope.
Testing Done
Manual Testing
Resolved Issues
Resolves #3355
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue