Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Global Parameters for Mock Global Path Node #221

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

SPDonaghy
Copy link
Contributor

@SPDonaghy SPDonaghy commented Dec 8, 2023

Description

Linked to Issue 49 in Local Pathfinding.

The purpose was to set some parameters, for the mock global path node, in the global params file rather than in the node's python file.

The added parameters are:

  1. global_path_filepath
  2. interval_spacing

Verification

  1. Run the global or local pathfinding launch file with development mode (default)
    ros2 launch local_pathfinding main_launch.py
    
  2. In a different terminal run some ros2 param commands
    ros2 param get /mgp_main global_path_filepath
    ros2 param set /mgp_main global_path_filepath /workspaces/sailbot_workspace/src/local_pathfinding/global_paths/path_2.csv
    

Resources

  • Link to the PR for this issue.

@SPDonaghy SPDonaghy self-assigned this Dec 8, 2023
@SPDonaghy SPDonaghy added enhancement New feature or request and removed enhancement New feature or request labels Dec 8, 2023
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the node name and documented verification steps. Once the comment below is resolved feel free to merge

src/global_launch/config/globals.yaml Show resolved Hide resolved
interval_spacing need only be a float
@SPDonaghy SPDonaghy merged commit 62e7804 into main Dec 8, 2023
12 checks passed
@SPDonaghy SPDonaghy deleted the user/SPDonaghy/add_new_global_params branch December 8, 2023 20:02
@SPDonaghy SPDonaghy restored the user/SPDonaghy/add_new_global_params branch December 9, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants