Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display backbone angle correctly when Geometry.base_pairs_per_turn is not 10.5 #996

Open
dave-doty opened this issue Sep 21, 2024 · 0 comments · Fixed by #997
Open

display backbone angle correctly when Geometry.base_pairs_per_turn is not 10.5 #996

dave-doty opened this issue Sep 21, 2024 · 0 comments · Fixed by #997
Assignees
@dave-doty
Labels
bug Something isn't working closed in dev Indicates issue is closed in the dev branch, available at: https://scadnano.org/dev/

Comments

@dave-doty
Copy link
Member

dave-doty commented Sep 21, 2024 •
edited
Loading

Currently, the Geometry parameter (whether in Design or a HelixGroup) is ignored when calculating the backbone angle to display in the side view when the slice bar is on, and it is assumed that it is always 10.5 bp/turn.
@dave-doty dave-doty self-assigned this Sep 21, 2024
@dave-doty dave-doty added the bug Something isn't working label Sep 21, 2024
dave-doty added a commit that referenced this issue Sep 21, 2024
@dave-doty
fixes #996: display backbone angle correctly when `Geometry.base_pair…
a83de1a 
…s_per_turn` is not 10.5
@dave-doty dave-doty linked a pull request Sep 21, 2024 that will close this issue
996 display backbone angle correctly when Geometry.base_pairs_per_turn is not 10.5 #997
Merged
@dave-doty dave-doty mentioned this issue Sep 21, 2024
Merged
@dave-doty dave-doty added the closed in dev Indicates issue is closed in the dev branch, available at: https://scadnano.org/dev/ label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dave-doty dave-doty

Labels
bug Something isn't working closed in dev Indicates issue is closed in the dev branch, available at: https://scadnano.org/dev/
Projects
None yet
Milestone
No milestone
1 participant
@dave-doty