-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
34 extensions on end of strand #800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ength to loopout.num_bases
…ode to include it
…h and display angle; no DNAEnds yet
…upright depending on display_angle
…tension path from left to right
…h, display angle, and number of bases
dave-doty
changed the title
2 extensions on end of strand
34 extensions on end of strand
Sep 8, 2022
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for single-stranded extensions on the end of a strand.
Related Issue
Closes #34
Motivation and Context
This will help in designs where some piece of a strand should be single-stranded, but there is not sufficient room on a helix to draw it there.
In the data model used by both the Python package and the Dart code implementing the web interface, an Extension is a new type of Substrand, i.e., it appears in the list of substrands (called
domains
in the Python package despite the fact that they can also have Loopouts and Extensions). As such, it shares certain features in common: it can have a name and a DNA sequence. It also has special properties, for exampledisplay_length
anddisplay_angle
that control its appearance in the web interface.How Has This Been Tested?
Unit tests were added similar to those in the Python package, and I also ran each of the new UI pieces manually.
Screenshots (if appropriate):