Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@renovatebot bumping versions will break the regression test every time #503

Closed
paddyroddy opened this issue Dec 3, 2024 · 2 comments · Fixed by #505
Closed

@renovatebot bumping versions will break the regression test every time #503

paddyroddy opened this issue Dec 3, 2024 · 2 comments · Fixed by #505
Assignees
@paddyroddy
Labels
bug Something isn't working

Comments

@paddyroddy
Copy link
Member

Are we sure we want this? Every time there's a new change, this test will have to be updated.

Originally posted by @paddyroddy in #432 (review)
@paddyroddy paddyroddy added the bug Something isn't working label Dec 3, 2024
@paddyroddy paddyroddy mentioned this issue Dec 3, 2024
Closed
@dstansby
Copy link
Member

dstansby commented Dec 3, 2024 •
edited
Loading

Could we get rennovate to bump the version in the regression test data file at the same time?

samcunliffe added a commit that referenced this issue Dec 3, 2024
@samcunliffe
Proposal to fix #503 by excluding version numbers from the regression…
ccdc5ce 
… test.
@paddyroddy paddyroddy mentioned this issue Dec 3, 2024
Merged
@paddyroddy
Copy link
Member Author

Could we get rennovate to bump the version in the regression test data file at the same time?

So that was the hope. But it turns out there was a blocker. #505 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@dstansby @paddyroddy