Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to profiling docs #348

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 2, 2024

  • Note that memory_profiler could be useful on Winows, where memray isn't available
  • Make memory_profiler orange (from red before). I don't think we should actively discourage using it, even if it is unmaintained at the moment it can still be useful (especially on Windows)
  • Split profiling tools up into sub-sections

Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is psutil meant to be there twice?

@dstansby
Copy link
Member Author

dstansby commented Apr 3, 2024

Woops, I think one of those entries was meant to be pyinstrument. Should be fixed now.

@paddyroddy paddyroddy self-requested a review April 3, 2024 09:46
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫐

@dstansby dstansby merged commit e773f05 into main Apr 3, 2024
15 checks passed
@dstansby dstansby deleted the profiling-improvements branch April 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants