Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Team Lc-Japanese tourist! #22

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Team Lc-Japanese tourist! #22

wants to merge 9 commits into from

Conversation

Sanli84Lu
Copy link

@HKmm02

yeah!

dpshelio
dpshelio requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things still to do. Please, also mention the issue this is referring to as instructed.

asia/Japan.md Show resolved Hide resolved
asia/Japan.md Outdated Show resolved Hide resolved
dpshelio
dpshelio requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestions mentioned are still unresolved. Please, try to rename the files as suggested. Ask us if you need some help with it.

@Sanli84Lu
Copy link
Author

I have resolved conflicts between branches and add link to Japan in the asia's readme file in the branch of lc. Is this correct?

@krishnakumarg1984
Copy link

krishnakumarg1984 commented Oct 18, 2024 •
edited
Loading

Getting better. Note that, in all the PRs that were successfully merged, the newly added entries are about an individual city within a country. Therefore, following this pattern, could you please

  1. Create a folder for japan under asia.
  2. Rename your Japan.md to README.md and place it under the above created japan folder
  3. Update the link to the aforesaid readme file from your README.md in the Asia folder
  4. Write a small paragraph in a new file bearing the same filename as the specific city in Japan that you would like to visit
  5. Create a README for Japan and provide a link to your city within it.

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpshelio dpshelio dpshelio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sanli84Lu @krishnakumarg1984 @dpshelio